Conversation
rocky
force-pushed
the
section-module-revision
branch
from
c1d40ae to
84b6c49
Compare
Graph Construction & Representation: https://reference.wolfram.com/language/guide/GraphConstructionAndRepresentation.html Move eval stuff to pymathics.graph.eval
This might be temporay though based on WMA docs
Contributor
|
Regarding docpipeline, I didn't copy here, but I am using the one in mathics-core. The idea is to reuse that one on each pymathics module. |
* Graph options need to be in System context. * Improve examples for GraphDistance and component sections * Add GraphDistance summary
rocky
force-pushed
the
section-module-revision
branch
from
84b6c49 to
91bef1e
Compare
mmatera
reviewed
Feb 12, 2023
| evaluate("SortList[list_] := Sort[Map[Sort, list]]") | ||
|
|
||
|
|
||
| def test_connected_components(): |
Member
Author
There was a problem hiding this comment.
In master at cb9f847 I am seeing this test twice. Once in test_algorithms.py, and once in test_generators.
But code in "algorithms" has been moved to components and other places. And there was a test in that which should have been in the non-existent test.test_base.
Commit 72f42d6 addresses both of these and reinstates another test that was commented out.
and one of the tests in algorithms beloned in test_base.py
rocky
force-pushed
the
section-module-revision
branch
from
fbd8837 to
72f42d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graph Construction & Representation:
https://reference.wolfram.com/language/guide/GraphConstructionAndRepresentation.html
Move eval stuff to pymathics.graph.eval
@mmatera when I run tests I am seeing 9 tests fail now rather than 8. I am not sure where the additional test is coming from. I am too frazzled right now to investigate.
Also, I notice that we now have common docpipeline code 3 places now and if we continue this direction with pymathics-natlang there will be 4 places. We should DRY this code and add the common code to a new module
mathics.doc.common_docpipeline. (Please let is not add tomathics.doc.common_docwhich is large enough as it is and does related but separate stuff.