Skip to content

Romberg is deprecated...#1131

Merged
rocky merged 1 commit intomasterfrom
remove-Romberg
Oct 22, 2024
Merged

Romberg is deprecated...#1131
rocky merged 1 commit intomasterfrom
remove-Romberg

Conversation

@rocky
Copy link
Copy Markdown
Member

@rocky rocky commented Oct 15, 2024

and will be removed by SciPyi 1.15

and will be removed by SciPyi 1.15
@rocky rocky requested a review from mmatera October 15, 2024 21:05
@rocky
Copy link
Copy Markdown
Member Author

rocky commented Oct 15, 2024

Scipy has dblquad, tplquad, and cumulative_trapezoid that we don't currently support. But that is left to someone who understands this better. It also looks like we don't use SciPy's simpson.

@mmatera
Copy link
Copy Markdown
Contributor

mmatera commented Oct 22, 2024

Scipy has dblquad, tplquad, and cumulative_trapezoid that we don't currently support. But that is left to someone who understands this better. It also looks like we don't use SciPy's simpson.

I didn't include these methods because they do not accept general functions as an argument. dblquad, tplquad only work for 2 and three variable functions respectively, while cumulative_trapezoid and simpson estimate integrals using arrays of numbers instead of functions.

Copy link
Copy Markdown
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky
Copy link
Copy Markdown
Member Author

rocky commented Oct 22, 2024

Scipy has dblquad, tplquad, and cumulative_trapezoid that we don't currently support. But that is left to someone who understands this better. It also looks like we don't use SciPy's simpson.

I didn't include these methods because they do not accept general functions as an argument. dblquad, tplquad only work for 2 and three variable functions respectively, while cumulative_trapezoid and simpson estimate integrals using arrays of numbers instead of functions.

Thanks for the explanation.

Down the line, it might be possible to analyze the expression passed to determine when these are applicable and handle these. However, with all the other stuff to do, that's best left for when a situation that needs these arises.

@rocky rocky merged commit 8c472bd into master Oct 22, 2024
@rocky rocky deleted the remove-Romberg branch October 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants