SameQ testing against Precision Real and adding SameQ unit tests#147
Merged
SameQ testing against Precision Real and adding SameQ unit tests#147
Conversation
rocky
reviewed
Feb 3, 2022
| other_value = other.value | ||
| else: | ||
| return False | ||
| value = self.value |
Member
There was a problem hiding this comment.
I think this logic could be simplified by moving it in the "then" branch above.
Also, I think the docstring here could be more detailed.
I also see that none of the Comparison operators appear in the docs.
I will put in a PR based on this to start to address this.
rocky
changed the title
* Simplify SameQ logic for MachineReal * Hook comparison operators into documentation * Fill out description and examples for SameQ Note: comparison.py probably should be split out into its own subsection As always, with recards to documentation, and sectioning gthere is a lot more there to do.
and document, add examples of that. Also be more explicit in $MachinePrecision example
Include SameQ changes
SameQ tweaks -
Member
|
Let's merge and continue.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #146:
sameQroutine forPrecisioRealandMachineRealto behave like in WMA.One alternative would be to ask to the sympy developer team to implement a similar fix.