-
-
Notifications
You must be signed in to change notification settings - Fork 61
ComplexPlot, ComplexPlot3D #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bdlucas1
commented
Nov 26, 2025
mmatera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Another thing that should be checked for new Builtin Functions is how the document renders. We have a pretty screwy tagging system currently that is pretty fussy. (I can't do that right now though.) |
| /doc/reference-of-built-in-symbols/graphics-and-drawing/drawing-options-and-option-values | ||
| </url> for a list of Plot options. | ||
| </dl> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to give some examples here and in ComplexPlot3D.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that as a separate PR because it'll take a bit of effort to get it right - I'm not set up to check the doc, I don't know the tagging system, and neither does my editor so it can't help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that later.
| ): | ||
| return make_plot(plot_options, evaluation, dim=3) | ||
| def emit(graphics, i, xyzs, quads): | ||
| # color-blind friendly palette from https://davidmathlogic.com/colorblind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting reference. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that while choosing a color scheme for my 3d visual diff tool https://github.com/bdlucas1/diff3d