Skip to content

Conversation

@bdlucas1
Copy link
Collaborator

image image

@bdlucas1 bdlucas1 requested review from mmatera and rocky November 26, 2025 17:32
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky
Copy link
Member

rocky commented Nov 27, 2025

Another thing that should be checked for new Builtin Functions is how the document renders. We have a pretty screwy tagging system currently that is pretty fussy.

(I can't do that right now though.)

/doc/reference-of-built-in-symbols/graphics-and-drawing/drawing-options-and-option-values
</url> for a list of Plot options.
</dl>
Copy link
Member

@rocky rocky Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to give some examples here and in ComplexPlot3D.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that as a separate PR because it'll take a bit of effort to get it right - I'm not set up to check the doc, I don't know the tagging system, and neither does my editor so it can't help.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that later.

):
return make_plot(plot_options, evaluation, dim=3)
def emit(graphics, i, xyzs, quads):
# color-blind friendly palette from https://davidmathlogic.com/colorblind
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting reference. Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that while choosing a color scheme for my 3d visual diff tool https://github.com/bdlucas1/diff3d

@bdlucas1 bdlucas1 merged commit 9481d26 into Mathics3:master Nov 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants