use JSON library to import JSON files #1583
Conversation
| context = "JSON`Import`" | ||
| messages = {"dec": "Decoding Error at `1`"} | ||
|
|
||
| def eval(self, filename, evaluation: Evaluation): |
There was a problem hiding this comment.
This (and the other eval routines) should be moved under mathics.eval
There was a problem hiding this comment.
Eventually I will do that, but this is just to help #1582
There was a problem hiding this comment.
Ok. You are on the honor system to make good on this. I am concerned that a number of the things that get put off don't get done.
LGTM.
There was a problem hiding this comment.
In concrete, the former implementation of the JSON imported does not work. I want to be able to import JSON to share lists of tests between WMA and the pytest system of Mathics, to narrow the differences in formatting, and maybe later, on other aspects.
In particular, the JSON implementation I wrote is quite small. A refactor of the importers would requiere to review the code of the HTML and XML importers, which are much more complex. In order to finish something, I need to focus on one problem...
There was a problem hiding this comment.
Ok. You are on the honor system to make good on this. I am concerned that a number of the things that get put off don't get done.
TODO/FIXME comments, Issues, Kanban boards, PMs, stand-ups, all-hands, ..., tell me when you want me to stop ...
rocky
changed the title
rocky
changed the title
This improves the support for reading JSON files needed in #1582.