Revise Nintegrate to allow scipy to be optional#374
Merged
Conversation
Closed
* NIntegrate[] no longer requires scipy. * There were a number of small changes/fixes involving NIntegrate. * NIntegrate tests have been expanded.
rocky
force-pushed
the
NIntegrate-without-scipy
branch
from
b3aafbc to
e2f02d6
Compare
mmatera
approved these changes
Jun 18, 2022
Contributor
mmatera
left a comment
mmatera
left a comment
There was a problem hiding this comment.
LGTM. Just a comment: according to https://docs.python.org/3/library/importlib.html
find_loader is Deprecated since version 3.4: Use importlib.util.find_spec() instead.
Member
Author
|
Ok. Thanks. Changed in master in 297c1f7 Python has been through many many many iterations of this import stuff and I still feel it is a little bit too complex and cumbersome compared to other languages. (Don't ask "how so" unless you expect to get a long rant.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/builtins/numbers