Skip to content

Conversation

@rocky
Copy link
Member

@rocky rocky commented Sep 13, 2022

  • Shy away from using markup that doesn't render properly in Django. In partuclar, math mode
  • Add Wiki and WMA links in Accuracy and Precision builtin functions, and
  • more cross refrences
  • Move unit tests in autodoc to unit test
  • reversed quote -> RawBackquote which is the WMA term for the character

@rocky rocky force-pushed the accuracy-and-precision-doc branch 2 times, most recently from f8fcf97 to df271c4 Compare September 13, 2022 18:41
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now this is ready.

Copy link
Contributor

@TiagoCavalcante TiagoCavalcante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a small typo

@rocky
Copy link
Member Author

rocky commented Sep 15, 2022

@mmatera @TiagoCavalcante Any objections to merging this?

rocky and others added 3 commits September 15, 2022 07:35
* Shy away from using markup that doesn't render properly in Django. In
  partuclar, math mode
* Add Wiki and WMA links in Accuracy and Precision builtin functions, and
* more cross refrences
* Move unit tests in autodoc to unit test
* reversed quote -> RawBackquote which is the WMA term for the character
@rocky rocky force-pushed the accuracy-and-precision-doc branch from 387ba55 to 585d856 Compare September 15, 2022 11:36
@mmatera
Copy link
Contributor

mmatera commented Sep 15, 2022

@mmatera @TiagoCavalcante Any objections to merging this?

Nop, go ahead!

@TiagoCavalcante
Copy link
Contributor

@mmatera @TiagoCavalcante Any objections to merging this?

No, this is great!

@rocky rocky merged commit a0f456b into master Sep 15, 2022
@rocky rocky deleted the accuracy-and-precision-doc branch September 15, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants