Bye-bye python_form parameter. #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding the prototype of to_python in BaseElement * adding type annotations to its paramenters. * removing the use of the parameter n_evaluation in ``expr.to_python(n_evaluation=evaluation)`` in favor of ``eval_N(expr, evaluation).to_python()`` * adding several comments.
rocky
reviewed
Sep 13, 2022
| return py_obj | ||
|
|
||
| # Notice that in this case, `to_python` returns a Mathics Expression object, | ||
| # instead of a builtin native object. |
Member
There was a problem hiding this comment.
I expect over time that more iterations over the code will be done and the thing that seem unusual will be addressed or there will be explanations of why they are the way they are.
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues #552. Now I removed the parameter
python_formfromto_pythonand replaced it with something local into the unique place where it is needed.