Skip to content

Comments

Go over mathics.builtin.system documentation#950

Merged
rocky merged 5 commits intoint-str-conversion-limitfrom
str-conversion-doc-and-test
Dec 18, 2023
Merged

Go over mathics.builtin.system documentation#950
rocky merged 5 commits intoint-str-conversion-limitfrom
str-conversion-doc-and-test

Conversation

@rocky
Copy link
Member

@rocky rocky commented Dec 16, 2023

This isn't quite right. Needs a pytest and the failing doctest needs going over.

But this is closer, I think

@rocky rocky force-pushed the str-conversion-doc-and-test branch from 476b82e to 423c5e3 Compare December 16, 2023 21:01
@rocky rocky marked this pull request as draft December 16, 2023 21:02
@rocky rocky requested a review from mmatera December 16, 2023 21:02
@rocky rocky force-pushed the str-conversion-doc-and-test branch from 423c5e3 to 43e923e Compare December 16, 2023 21:03
@mmatera
Copy link
Contributor

mmatera commented Dec 18, 2023

@rocky, thanks for the rewriting. I tried to merge it with the part I rewrote.
The problem with the tests is that in Python <3.10 the exception is not raised, and the function used to set the value is not available. By now, I think the best is to leave the results of the tests with a wildcard.

@rocky rocky force-pushed the str-conversion-doc-and-test branch 2 times, most recently from 443b098 to 2b7b08a Compare December 18, 2023 22:28
@rocky
Copy link
Member Author

rocky commented Dec 18, 2023

@rocky, thanks for the rewriting. I tried to merge it with the part I rewrote. The problem with the tests is that in Python <3.10 the exception is not raised, and the function used to set the value is not available. By now, I think the best is to leave the results of the tests with a wildcard.

Thanks for the information. Okay tests have been weakened. See if I have this and the commentary right though. Feel free to just commit on top of this.

@mmatera
Copy link
Contributor

mmatera commented Dec 18, 2023

Excellent. Let's merge this into the other branch when the tests finish.

@mmatera mmatera marked this pull request as ready for review December 18, 2023 22:46
@rocky rocky force-pushed the str-conversion-doc-and-test branch from b35c528 to c2e870f Compare December 18, 2023 22:46
@rocky rocky changed the title Go over documentation Go over mathics.builtin.system documentation Dec 18, 2023
@rocky rocky merged commit f58e170 into int-str-conversion-limit Dec 18, 2023
@rocky rocky deleted the str-conversion-doc-and-test branch December 18, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants