fix: using reasonToCode instead of using hard coded shutdown codes …
#85
+37
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tegefaulkes
force-pushed
the
fix-reject-code
branch
from
c7eee38 to
612a76e
Compare
…for streams * Related: #77 [ci skip]
tegefaulkes
force-pushed
the
fix-reject-code
branch
from
612a76e to
bcd557b
Compare
CMCDragonkai
reviewed
Feb 6, 2024
| } | ||
| })(); | ||
| await expect(asd).rejects.toThrow('read 1'); | ||
| await expect(code).rejects.toThrow('read 0'); |
There was a problem hiding this comment.
I think this test should be more precise, if you are providing a reasonToCode.
There was a problem hiding this comment.
I can add a new issue to expand the tests for this.
CMCDragonkai
reviewed
Feb 6, 2024
Comment on lines
+1009
to
+1013
| this.conn.streamShutdown( | ||
| streamId, | ||
| Shutdown.Write, | ||
| this.reasonToCode('write', errors.ErrorQUICConnectionStopping), | ||
| ); |
There was a problem hiding this comment.
Does the end user ever see the "code" for this?
There was a problem hiding this comment.
I believe so, yeah. Streams get codes when shutdown. Connections get codes and a message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the use of hard-coded error codes for shutting down quiche streams by using codes provided by
reasonToCodeIssues Fixed
reasonToCodefor code when rejecting new streams #77Tasks
streamShutdownand use codes provided byreasonToCode.Final checklist