Skip to content

Synchronising changes from js-logger#4

Merged
CMCDragonkai merged 5 commits intostagingfrom
feature-logger-update
Jul 22, 2022
Merged

Synchronising changes from js-logger#4
CMCDragonkai merged 5 commits intostagingfrom
feature-logger-update

Conversation

@emmacasolin
Copy link
Copy Markdown
Contributor

@emmacasolin emmacasolin commented Jul 22, 2022

Description

Updating CI/CD including:

  • Continuous benchmarking
  • Staging branch
  • Advanced type checking

Tasks

  • 1. Create new staging branch
  • 2. Synchronise changes from js-logger

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@emmacasolin emmacasolin added the development Standard development label Jul 22, 2022
@emmacasolin emmacasolin self-assigned this Jul 22, 2022
@emmacasolin
Copy link
Copy Markdown
Contributor Author

Should the benchmarks here be changed to be done continuously in the CI/CD (like js-logger) or be left as is? @CMCDragonkai

@CMCDragonkai
Copy link
Copy Markdown
Member

Yea benches should be migrated over to the same style. It's fairly easy to copy, similar index.js and more.

@CMCDragonkai
Copy link
Copy Markdown
Member

Should update all the package.json dependencies to match.

@CMCDragonkai
Copy link
Copy Markdown
Member

I'll run the benchmarks here, so you can move on to other libraires.

Comment thread benches/index.ts Outdated
Comment thread benches/WorkerManager.ts
@CMCDragonkai
Copy link
Copy Markdown
Member

I'll need to add this into codesee too after you merge it.

At the same time... try generating the docs as well, and squash it all.

@CMCDragonkai
Copy link
Copy Markdown
Member

And the scripts all require executable permission.

@emmacasolin emmacasolin force-pushed the feature-logger-update branch from 5b18f13 to 7c591cd Compare July 22, 2022 04:41
@emmacasolin emmacasolin marked this pull request as ready for review July 22, 2022 04:42
@CMCDragonkai
Copy link
Copy Markdown
Member

It looks like ts-node using swc fails to run the benchmarks because the decorator plus symbol properties are not being compiled properly. Disabling and removing swc makes the benchmarks work again. This may be related to swc-project/swc#5189.

So for this project we'll need to switch off the usage of swc. But this creates a problem, any benchmarking for PK which relies on the async-init will end up not working. We will need swc upstream to be fixed.

@CMCDragonkai
Copy link
Copy Markdown
Member

I posted a linked bug here TypeStrong/ts-node#1844.

So for now swc could affect any benchmarks running in ts-node too... Basically any call ready wrapped functions. Be wary of this, you may wish to disable the swc: true in those other repos. But we will keep swc where we can until we can make use of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Standard development

Development

Successfully merging this pull request may close these issues.

2 participants