Potential fix for code scanning alert no. 12: Uncontrolled command line - #732
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
mrzt721010
marked this pull request as ready for review
September 2, 2026 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use strict allowlisting for user-selectable file arguments before appending to
cmd.Best fix here (without changing behavior materially): normalize to basename and only allow known-safe
.txtnames from a predefined set (or at minimum from a tight pattern plus basename enforcement). This blocks path tricks and arbitrary file selection while preserving existing API behavior for valid values.In
web/app.py, instart_attack():ALLOWED_LIST_FILES) near other constants.proxylist,amp_file, andproxy_file, accept only values present in this allowlist; otherwise use safe defaults / skip optional arg.Popen(..., shell=False)behavior unchanged.