Add Material3 style dependency - #4
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id = "1", | ||
| title = "Interstellar", | ||
| posterUrl = "https://image.tmdb.org/t/p/w500/nBNZadXqJSdt05SHLqgT0HuC5Gm.jpg", | ||
| overview = "A team travels through a wormhole in search of a new home for humanity.", |
There was a problem hiding this comment.
Request internet permission for remote poster images
The sample data uses remote TMDB poster URLs and AsyncImage fetches them over the network, but the AndroidManifest declares no <uses-permission android:name="android.permission.INTERNET">. On a device the Coil requests will fail with network security errors and posters never render even though the UI assumes they load. Add the internet permission so the remote artwork can be fetched.
Useful? React with 👍 / 👎.
| echo "Java not found, please install JDK" >&2 | ||
| exit 1 | ||
| } | ||
|
|
||
| exec "$JAVA_CMD" -Dorg.gradle.appname=gradlew -classpath "$DIR/gradle/wrapper/gradle-wrapper.jar" org.gradle.wrapper.GradleWrapperMain "$@" |
There was a problem hiding this comment.
Ship Gradle wrapper JAR with new wrapper scripts
The new gradlew script boots Gradle via gradle/wrapper/gradle-wrapper.jar, but that JAR is not present anywhere in the repository, so running ./gradlew will exit with Could not find or load main class org.gradle.wrapper.GradleWrapperMain and the project cannot be built via the wrapper. Commit the wrapper JAR (or use a non-wrapper entrypoint) so builds work out of the box.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task