refactor: Tidy up some code - #141
Merged
Merged
Conversation
MaxG87
force-pushed
the
move-helper-functions
branch
2 times, most recently
from
July 22, 2026 18:35
a6e386d to
da45d5e
Compare
Moving this helper caused some mock based tests to fail. They were rewritten to stop using mocking. Instead, they use a spy to ensure the expected refresh commands were issued. Working on this revealed an edge-case bug. When no files or folders were configured to be backed up, the restic backend crashed due to a crash of restic. This is prevented by a guard now.
This reduces the length of the main shell-interface file, improving maintainability.
The logging functionality was never used, for years. A major release seems to be the best opportunity to get rid of it.
MaxG87
force-pushed
the
move-helper-functions
branch
from
July 22, 2026 19:14
da45d5e to
c79226f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many helper functions were moved to shell-interface. A all-project
conftest.py was created and a first fixture deduplicated. Both
libraries got rid of
loguru. That functionality was unused and amajor release is a good opportunity to tidy up.