Create a new Assembly Attribute for an easy Soft Dependency#56
Merged
Conversation
Xilophor
added a commit
that referenced
this pull request
Mar 22, 2024
)" This reverts commit 1d29571.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, for soft dependencies, you have to register your mod with the method provided, which modders would have to use a somewhat weird way to access that method only when this mod is loaded. Attributes are significantly easier and generally do not cause issues during runtime, however the current attribute causes issues due to how BepInEx attempts to load the "plugin" class - including the attribute - at runtime.
For this, a new attribute - currently called
SoftLobbyCompatibility- is added in this PR. It is an assembly attribute that can be used to register a mod only when the Lobby Compatibility mod is loaded. The attribute is simple and clean.