Revert "Create a new Assembly Attribute for an easy Soft Dependency"#64
Merged
Merged
Conversation
)" This reverts commit 1d29571.
MaxWasUnavailable
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #56
Due to NGO using Assembly.GetCustomAttributes(Type, bool) and a potential flaw(?) in that method, it loads all attributes of the assembly, including the
SoftLobbyCompatibilityattribute, which may not have an assembly to reference (soft dependency).This causes an error to occur when running that method, preventing NGO from working. The only available solution without potential side-effects is to just go back to using the Register method previously/currently provided.