fix: preserve credentials during connection renames - #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Follow-up to #289. The per-connection save path is correct, but its initial rename ordering could delete credentials before omitted values were recovered or before destination writes succeeded.
Verification
uv run pytest -q tests/test_connection_store_save_one.py tests/test_credentials_connection_store.py tests/test_credentials_keyring.py— 46 passeduv run pytest -q tests --ignore=tests/integration -k 'not test_detect_strategy_pip_user_fallback'— 1,817 passed, 555 skipped, 1 known environment-sensitive test deselectedRegression coverage includes omitted DB/SSH credentials, failed migration reads, partial destination writes, raw backend failures, rollback behavior, and preservation of an existing destination entry.