lint: fix the two issues keeping the test workflow red on main - #269
Merged
Conversation
golangci-lint in the test job has failed on main since 2026-08-26 on two findings: server/routes_generate_test.go not gofumpt-formatted (one literal), and x/mlxrunner/client_env_test.go restoring an environment variable with os.Setenv inside t.Cleanup, which usetesting rejects. gofumpt the former; in the latter let t.Setenv register the restore and keep only the os.Unsetenv that is the state under test. All 64 test packages already passed; this only turns the job green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testworkflow has been red onmainsince 2026-08-26 — not on tests (all 64 packages pass; #267's re-run shows the same) but on golangci-lint:server/routes_generate_test.go:2838not gofumpt-formatted, andx/mlxrunner/client_env_test.go:29usingos.Setenvin at.Cleanup(usetesting). gofumpt for the first; for the second,t.Setenvregisters the restore and only theos.Unsetenvunder test remains. Verified with golangci-lint 2.13.2 at repo root (the only remaining findings are the dead constrain layer #267 deletes) andgo test ./server/ ./x/mlxrunner/.🤖 Generated with Claude Code