Skip to content

fix: bundle Windows runtime required at startup - #4

Merged
McanKul merged 1 commit into
developmentfrom
fix/windows-startup-runtime
Jul 22, 2026
Merged

fix: bundle Windows runtime required at startup#4
McanKul merged 1 commit into
developmentfrom
fix/windows-startup-runtime

Conversation

@McanKul

@McanKul McanKul commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Root cause

The HEIC decoder added in v0.2.1 makes offpdf.exe import MSVCP140.dll. The Windows installer contained the Visual C++ runtime only under binaries/, but the Windows loader needs it beside offpdf.exe before any application code can run. Clean Windows machines therefore exited before opening a window.

Fix

  • bundle MSVCP140 and its VCRUNTIME dependencies beside the main executable on Windows
  • keep the resource mapping Windows-only so macOS builds remain portable
  • install and launch the packaged NSIS application in CI before publishing
  • prepare patch release v0.2.2

Validation

  • frontend production build
  • 21 frontend tests
  • Rust check
  • verified v0.2.1 executable imports MSVCP140.dll while installer placed it in the wrong directory
  • packaged Windows launch smoke test (release workflow)

@McanKul
McanKul merged commit f75e156 into development Jul 22, 2026
2 checks passed
@McanKul
McanKul deleted the fix/windows-startup-runtime branch July 22, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant