-
Notifications
You must be signed in to change notification settings - Fork 106
CI runners clean-up #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI runners clean-up #104
Conversation
macOS 10.15 was removed from GHA long ago. https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
| fail-fast: false | ||
| matrix: | ||
| macos-version: ['10.15'] | ||
| macos-version: ['11'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the actual problem is the missing support for Python 2.7, also with the previous runner. I'm not sure how to test Python 2.7 on MacOS at all with that problem...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, and I just saw:
Warning: The support for python 2.7 will be removed on June 19
for the Windows build, so the same problem here :(
|
@mrbean-bremen Seems like we have two different issues to address.
What is your opinion, if there are any good reasons to keep CI builds with the Python 2.7 on modern OSes? Probably, the Centos7 build is enough to check a backward compatibility. |
This is actually what I also thought, but wanted to wait for your opinion. So, yes - I see no reason to preserve the other 2.7 CI builds (also considering that the effort to install 2.7 will only ever increase). |
|
As long as it continues to work with Python 2.7 on CentOS 7 as RHEL 7 is still in support window and in production use for a few more years. |
|
Thought would be nice with test builds on Rocky 9 (RHEL 9) as that may be the next platform for those moving on up from CentOS 7 (RHEL 7) in the coming years once extended support expires. Rocky 9 would be Python 3.9. |
As long as the docker container is available, this should not be a problem.
Sure, this should be easy to setup if needed. |
3e44086 to
607b32b
Compare
| macos-version: ['10.15'] | ||
| python-version: ['2.7'] | ||
| macos-version: ['11'] | ||
| python-version: ['3.6'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, 3.6 will be supported a bit longer by GH Actions, but eventually it will also go... Well we can deal with it when it becomes a problem.
|
Ready for review (and squash-merge). The check fails because of |
| container_os_python_package: ['python-debug'] | ||
| configuration: ['debug', 'release'] | ||
| include: | ||
| - container_os: 'rockylinux' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - @he-hesce will be happy 😄
|
:-) I and everyone supporting production systems for 10-20 years from original release will be happy. |
https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/