Skip to content

Conversation

@iakov
Copy link
Contributor

@iakov iakov commented Jun 26, 2023

  1. macOS 10.15 was removed from GHA long ago.
    https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
  2. Python 2.7 is obsolete, thus removed for Windows and macOS, but still in CentOS7
  3. RockyLinux9 is here for CI from now on

fail-fast: false
matrix:
macos-version: ['10.15']
macos-version: ['11']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the actual problem is the missing support for Python 2.7, also with the previous runner. I'm not sure how to test Python 2.7 on MacOS at all with that problem...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and I just saw:

Warning: The support for python 2.7 will be removed on June 19

for the Windows build, so the same problem here :(

@iakov
Copy link
Contributor Author

iakov commented Jun 28, 2023

@mrbean-bremen Seems like we have two different issues to address.

  1. macOS 10.15 runner is outdated. And I propose to silently shift to the available one.
  2. python 2.7 is unavailable for "low-effort" installation, but can be installed after some additional work.

What is your opinion, if there are any good reasons to keep CI builds with the Python 2.7 on modern OSes? Probably, the Centos7 build is enough to check a backward compatibility.

@mrbean-bremen
Copy link
Contributor

Probably, the Centos7 build is enough to check a backward compatibility.

This is actually what I also thought, but wanted to wait for your opinion. So, yes - I see no reason to preserve the other 2.7 CI builds (also considering that the effort to install 2.7 will only ever increase).

@he-hesce
Copy link
Contributor

As long as it continues to work with Python 2.7 on CentOS 7 as RHEL 7 is still in support window and in production use for a few more years.

@he-hesce
Copy link
Contributor

he-hesce commented Jun 28, 2023

Thought would be nice with test builds on Rocky 9 (RHEL 9) as that may be the next platform for those moving on up from CentOS 7 (RHEL 7) in the coming years once extended support expires. Rocky 9 would be Python 3.9.

@mrbean-bremen
Copy link
Contributor

As long as it continues to work with Python 2.7 on CentOS 7 as RHEL 7 is still in support window and in production use for a few more years

As long as the docker container is available, this should not be a problem.

Thought would be nice with test builds on Rocky 9 (RHEL 9) as that may be the next platform for those moving on up from CentOS 7 (RHEL 7) in the coming years once extended support expires. Rocky 9 would be Python 3.9.

Sure, this should be easy to setup if needed.

@iakov iakov changed the title macOS 10.15 runner removed CI runners clean-up Jul 6, 2023
@iakov iakov marked this pull request as draft July 6, 2023 17:34
@iakov iakov force-pushed the patch-4 branch 4 times, most recently from 3e44086 to 607b32b Compare July 6, 2023 17:46
macos-version: ['10.15']
python-version: ['2.7']
macos-version: ['11']
python-version: ['3.6']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, 3.6 will be supported a bit longer by GH Actions, but eventually it will also go... Well we can deal with it when it becomes a problem.

@iakov iakov marked this pull request as ready for review July 7, 2023 11:09
@iakov iakov requested a review from mrbean-bremen July 7, 2023 11:16
@iakov
Copy link
Contributor Author

iakov commented Jul 7, 2023

Ready for review (and squash-merge). The check fails because of qt.io download access problem, might be it can be just re-run once again.

container_os_python_package: ['python-debug']
configuration: ['debug', 'release']
include:
- container_os: 'rockylinux'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - @he-hesce will be happy 😄

@mrbean-bremen mrbean-bremen merged commit b3b0773 into MeVisLab:master Jul 7, 2023
@he-hesce
Copy link
Contributor

he-hesce commented Jul 7, 2023

:-) I and everyone supporting production systems for 10-20 years from original release will be happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants