Skip to content

CI runners clean-up #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 7, 2023
Merged

CI runners clean-up #104

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ca5b8c1
macOS 10.15 runner removed
iakov Jun 26, 2023
0753b1b
No Python 2.7 on Win anymore
iakov Jun 29, 2023
b438289
Add RockyLinux to GHA CI
iakov Jun 29, 2023
92d7be3
Remove Python 2.7 on macOS
iakov Jun 29, 2023
062eca1
Fix artifact names
iakov Jun 29, 2023
e56c2d3
GHA: use older 3.6 on Windows with mingw53
iakov Jun 29, 2023
607b32b
GHA: unified jobs for Centos7 and RockyLinux9
iakov Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,23 +82,29 @@ jobs:
name: wrappers_ubuntu_22_04
path: generated_cpp

centos:
oldschool:
strategy:
fail-fast: false
matrix:
container:
- 'centos:7'
container_os: ['centos']
container_os_version: ['7']
container_os_python_package: ['python-debug']
configuration: ['debug', 'release']
include:
- container_os: 'rockylinux'
Copy link
Contributor

@mrbean-bremen mrbean-bremen Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - @he-hesce will be happy 😄

container_os_version: '9'
container_os_python_package: 'python3-devel'
configuration: 'release'
runs-on: ubuntu-latest
container: ${{ matrix.container }}
container: '${{ matrix.container_os }}:${{ matrix.container_os_version }}'
steps:
- name: Install Qt
run: |
yum update -y
yum groupinstall "Development Tools" -y
yum install -y \
which \
python-debug \
${{ matrix.container_os_python_package }} \
qt5-qtbase-* \
qt5-qttools* \
qt5-qtsvg \
Expand All @@ -114,40 +120,37 @@ jobs:
run: |
export QT_SELECT=qt5
echo ======= SYSTEM INFO ========
uname -a; gcc --version | grep "gcc"; python --version; qmake-qt5 --version
which python 2>/dev/null && export PYTHON_VERSION_SUFFIX= || export PYTHON_VERSION_SUFFIX=3
uname -a; gcc --version | grep "gcc"; python${PYTHON_VERSION_SUFFIX} --version; qmake-qt5 --version
echo ============================
qmake-qt5 -r PythonQt.pro CONFIG+=${{ matrix.configuration }} \
PYTHON_VERSION=$(python --version | cut -d " " -f 2 | cut -d "." -f1,2) \
PYTHON_DIR=$(which python | xargs dirname | xargs dirname)
PYTHON_VERSION=$(python${PYTHON_VERSION_SUFFIX} --version | cut -d " " -f 2 | cut -d "." -f1,2) \
PYTHON_DIR=$(which python${PYTHON_VERSION_SUFFIX} | xargs dirname | xargs dirname)
make -j 2 && make check TESTARGS="-platform offscreen"

- name: Generate Wrappers
run: |
# workaround to allow to find the Qt include dirs for installed standard qt packages
mkdir /usr/include/qt5ln; ln -s /usr/include/qt5 /usr/include/qt5ln/include
export QTDIR=/usr/include/qt5ln
cd generator
./pythonqt_generator

- name: Upload Wrappers
uses: actions/upload-artifact@v3
with:
name: wrappers_centos7
name: wrappers_${{ matrix.container_os }}-${{ matrix.container_os_version }}_${{ matrix.configuration }}
path: generated_cpp

macOS:
strategy:
fail-fast: false
matrix:
macos-version: ['10.15']
python-version: ['2.7']
macos-version: ['11']
Copy link
Contributor

@mrbean-bremen mrbean-bremen Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the actual problem is the missing support for Python 2.7, also with the previous runner. I'm not sure how to test Python 2.7 on MacOS at all with that problem...

Copy link
Contributor

@mrbean-bremen mrbean-bremen Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, and I just saw:

Warning: The support for python 2.7 will be removed on June 19

for the Windows build, so the same problem here :(

python-version: ['3.6']
Copy link
Contributor

@mrbean-bremen mrbean-bremen Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, 3.6 will be supported a bit longer by GH Actions, but eventually it will also go... Well we can deal with it when it becomes a problem.

qt-version: ['5.9.*']
configuration: ['release','debug']
include:
- macos-version: '11'
python-version: '3.6'
qt-version: '5.11.*'
configuration: 'release'
- macos-version: '12'
python-version: '3.11'
qt-version: '5.12.*'
Expand Down Expand Up @@ -241,7 +244,7 @@ jobs:
# msvc-toolset: '14.16'

- qt-arch: 'win32_mingw53'
python-version: '2.7'
python-version: '3.6'
python-arch: 'x86'
qt-version: '5.11.*'

Expand Down