Respect a given runtime for live tv and recordings#2443
Closed
puenktchen wants to merge 1 commit intoMediaBrowser:betafrom
Closed
Respect a given runtime for live tv and recordings#2443puenktchen wants to merge 1 commit intoMediaBrowser:betafrom
puenktchen wants to merge 1 commit intoMediaBrowser:betafrom
Conversation
If a tv backend provides this information already, than it's doing it for a good reason. There's no reason to overwrite the runtime in such a case with one determined by ffprobe. A particular use case is an inprogress recording with a file as input. This results in wrong durations in the players if ffprobe's RunTimeTicks are used.
|
|
Member
|
Is this still needed? |
Contributor
Author
|
I don't think so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a tv backend provides this information already, than it's doing it for a good reason.
There's no reason to overwrite the runtime in such a case with one determined by ffprobe.
A particular use case is an inprogress recording with a file as input. This results in wrong durations in the players if ffprobe's RunTimeTicks are used.