Skip to content

Conversation

@kylehg
Copy link
Contributor

@kylehg kylehg commented Oct 8, 2015

Hello @majelbstoat, @xiao,

Please review the following commits I made in branch 'kyle-pypi'.

9a4d007edf00fbfce295d358511e953049ada9f7 (2015-10-07 17:35:24 -0700)
Setup PyPi

R=@majelbstoat
R=@xiao

MANUAL TESTING=not manually tested

Code review reminders. By giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to our style guides
  • Incomplete code is marked with TODOs
  • Logging and metrics are suitable

@xiao
Copy link

xiao commented Oct 8, 2015

LGTM

kylehg added a commit that referenced this pull request Oct 8, 2015
@kylehg kylehg merged commit 80be1a5 into master Oct 8, 2015
@kylehg kylehg deleted the kyle-pypi branch October 8, 2015 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants