Fix CASE refit classes #3663
Merged
Fix CASE refit classes #3663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CASE is a Class D refit. Removing CASE is not, so simply changing it does not necessarily make a refit Class D. In addition, the current designation of Class E is never applicable.
Windchild292
approved these changes
May 9, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3663 +/- ##
=========================================
Coverage 10.65% 10.66%
- Complexity 5472 5473 +1
=========================================
Files 830 830
Lines 113500 113499 -1
Branches 17156 17155 -1
=========================================
Hits 12099 12099
Misses 100194 100194
+ Partials 1207 1206 -1
☔ View full report in Codecov by Sentry. |
CASE refit penalties are only applied if no CASE of any sort was present in the location previously. This means that Clan units never receive the penalty, as they always have basic CASE integrated at minimum.
Contributor
Author
|
I briefly tested this by opening a campaign save: it seems to work as expected.
I only tested 'Mechs, admittedly, but given how CASE works in other units that shouldn't be relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CASE is a Class D refit. Removing CASE is not, so simply changing it does not necessarily make a refit Class D.
In addition, the current designation of Class E is never applicable.