Skip to content

fix: handle string-type message in suggestion handler#1214

Merged
CaralHsi merged 1 commit intoMemTensor:dev-20260309-v2.0.9from
CaralHsi:fix/suggestion
Mar 12, 2026
Merged

fix: handle string-type message in suggestion handler#1214
CaralHsi merged 1 commit intoMemTensor:dev-20260309-v2.0.9from
CaralHsi:fix/suggestion

Conversation

@CaralHsi
Copy link
Collaborator

@CaralHsi CaralHsi commented Mar 12, 2026

Description

  • Handle str input by using it directly as dialogue context
  • Guard against RawMessageList elements missing role/content keys
  • Fallback str() conversion for non-string content fields
  • Align type annotations with MessagesType

Related Issue (Required): Fixes #1215

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test

  • Test Script Or Test Steps (please provide)

  • Pipeline Automated API Test (please provide)

  • /suggestions with string message returns normally

  • /suggestions with list[dict] message works as before

  • /suggestions with message=None falls back to recent memories

Checklist

  • I have performed a self-review of my own code | 我已自行检查了自己的代码
  • I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释
  • I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常
  • I have created related documentation issue/PR in MemOS-Docs (if applicable) | 我已在 MemOS-Docs 中创建了相关的文档 issue/PR(如果适用)
  • I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR(如果适用)
  • I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人

Reviewer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed
  • Tests have been provided

@CaralHsi CaralHsi changed the title fix: suggestion fix: handle string-type message in suggestion handler Mar 12, 2026
@CaralHsi CaralHsi marked this pull request as ready for review March 12, 2026 03:42
@CaralHsi CaralHsi merged commit 39451ae into MemTensor:dev-20260309-v2.0.9 Mar 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant