fix(install.sh): comprehensive UX polish for installer output#1551
Merged
Conversation
- Fix box-drawing alignment: emoji (🧠, ✨) occupy 2 display columns, standardize all boxes to 50-col interior width with manual padding - Fix "Terminated: 15" noise from background process kills by using disown before kill - Fix ANSI escape codes leaking in output by switching printf from %s to %b format specifier - Suppress npm postinstall noise by redirecting stdout/stderr - Add numbered step indicators ([1] [2] [3]...) for install progress - Add spinner with elapsed time for viewer readiness check, remove premature lsof shortcut that returned before HTTP was actually ready - Gracefully handle launchctl kickstart conflict when macOS launchd KeepAlive auto-restarts the gateway after stop - Proactively free Hermes port before smoke test to avoid stale process conflicts from OpenClaw gateway reload - Improve interactive picker with [] brackets and emoji per option, right-align option keys - Rename banner to "MemOS Local Plugin Installer" - Consolidate better-sqlite3 warning from 4 lines to 1 line + tip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
│aligns correctlydisownfor background smoke-test processes so bash doesn't print job-control messages on killprintffrom%sto%bso embedded\033[…sequences render as colors instead of literal textnpm installoutput to avoid> node scripts/postinstall.cjsandup to date in 12scluttering the install log[1] [2] [3]…progress indicators make the install flow easy to followlsofshortcut with actual HTTP check (curl) + spinner with elapsed timer — prevents "installed successfully" when viewer isn't actually ready yetKeepAliveauto-restarts the gateway afteropenclaw gateway stop, detect the already-running gateway instead of reporting a false error:18800before smoke test to avoid "port already in use" skip[]brackets, emoji per option (🦞 OpenClaw, 👩 Hermes, 📦 Both), right-aligned option keys🧠 MemOS Local Plugin InstallerTest plan
bash install.sh --version 2.0.0-beta.1with both OpenClaw and Hermes installed\033[codes in outputcurl ... | bash -s -- --version ...)