fix: reduce empty episodes, finalize idle episodes, filter auto-skill prompts

apps/memos-local-plugin/adapters/hermes/memos_provider/__init__.py

@@ -48,6 +48,7 @@
 import contextlib
 import json
 import logging
+import re
 import sys
 import threading
 import time
@@ -62,7 +63,7 @@
 if str(_PLUGIN_DIR) not in sys.path:
     sys.path.insert(0, str(_PLUGIN_DIR))
 
-from bridge_client import MemosBridgeClient  # noqa: E402
+from bridge_client import BridgeError, MemosBridgeClient  # noqa: E402
 from daemon_manager import ensure_bridge_running, shutdown_bridge  # noqa: E402
 
 
@@ -142,7 +143,13 @@ def initialize(self, session_id: str, **kwargs: Any) -> None:  # type: ignore[ov
             logger.warning("MemOS: failed to start bridge — %s", err)
             return
         try:
-            self._bridge = MemosBridgeClient()
+            # Try TCP mode first (connect to daemon bridge).
+            # Falls back to stdio (spawn subprocess) if daemon isn't running.
+            try:
+                self._bridge = MemosBridgeClient(tcp_host="127.0.0.1", tcp_port=18911)
+            except BridgeError:
+                logger.info("MemOS: TCP daemon not available, falling back to stdio bridge")
+                self._bridge = MemosBridgeClient()
             resp = self._bridge.request(
                 "session.open",
                 {
@@ -156,12 +163,9 @@ def initialize(self, session_id: str, **kwargs: Any) -> None:  # type: ignore[ov
                 },
             )
             self._session_id = resp.get("sessionId") or session_id
-            ep = self._bridge.request("episode.open", {"sessionId": self._session_id})
-            self._episode_id = ep.get("episodeId", "")
             logger.info(
-                "MemOS: bridge ready session=%s episode=%s platform=%s",
+                "MemOS: bridge ready session=%s platform=%s",
                 self._session_id,
-                self._episode_id,
                 self._platform,
             )
         except Exception as err:
@@ -455,6 +459,10 @@ def on_session_end(self, messages: list[dict[str, Any]]) -> None:  # type: ignor
         if pending:
             with contextlib.suppress(Exception):
                 self._turn_end(*pending)
+        # Close the episode and session so the core stamps closure metadata
+        # (e.g. session.meta.closedAt). In TCP mode this ensures the daemon
+        # can distinguish "normal shutdown" from "abrupt disconnect" on
+        # restart, preventing orphan retention.
         with contextlib.suppress(Exception):
             self._bridge.request("episode.close", {"episodeId": self._episode_id})
         with contextlib.suppress(Exception):
@@ -488,6 +496,17 @@ def _turn_start(self, query: str, *, session_id: str = "") -> str:
             return ""
         return f"## Recalled Memories\n{context}"
 
+    # Hermes injects a structured auto-skill evaluation prompt at task end:
+    #   "Review the conversation above and consider whether a skill should
+    #    be saved or updated. Work in this order… SURVEY … THINK CLASS-FIRST …"
+    # Capturing this system-level scaffolding as conversation content pollutes
+    # memory search, task summaries, and downstream skill generation.
+    _AUTO_SKILL_EVAL_RE = re.compile(
+        r"^Review the conversation above and consider whether a "
+        r"skill should be saved or updated\.",
+        re.MULTILINE,
+    )
+
     def _turn_end(
         self,
         user_content: str,
@@ -497,6 +516,14 @@ def _turn_end(
     ) -> None:
         if not self._bridge:
             return
+        # Strip Hermes auto-skill evaluation blocks from the assistant
+        # response. When the header phrase is present the entire remainder
+        # of the message is system-generated scaffolding, not user content.
+        m = self._AUTO_SKILL_EVAL_RE.search(assistant_content)
+        if m:
+            assistant_content = assistant_content[: m.start()].strip()
+        if not assistant_content.strip() and not user_content.strip():
+            return
         self._bridge.request(
             "turn.end",
             {