fix: skip instructional prompts in auto-recall query normalization#1594
Closed
SonicBotMan wants to merge 1 commit intoMemTensor:mainfrom
Closed
fix: skip instructional prompts in auto-recall query normalization#1594SonicBotMan wants to merge 1 commit intoMemTensor:mainfrom
SonicBotMan wants to merge 1 commit intoMemTensor:mainfrom
Conversation
The normalizeAutoRecallQuery() function was passing long instructional prompts (like Hermes Agent's _SKILL_REVIEW_PROMPT) to FTS5 search, causing query failures and wasted LLM calls. Added detection for: - Prompts > 300 chars (almost certainly system instructions) - 'You are...' system prompt patterns - 'Review the conversation above...' Hermes review prompts This fixes FTS5 query failures and improves auto-recall efficiency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
normalizeAutoRecallQuery()function inapps/memos-local-openclaw/index.tspasses long instructional prompts to FTS5 search, causing query failures and wasted LLM calls.Root Cause
When used with Hermes Agent, the
before_prompt_buildhook receives internal agent prompts (like_SKILL_REVIEW_PROMPT) that are:These prompts cause:
filterRelevant()receives empty responses from DeepSeek reasoning modelsExample Failing Prompt
Solution
Added early detection for instructional prompts in
normalizeAutoRecallQuery():Testing
Verified locally with Hermes Agent v0.10.0 + MemTensor v1.0.4:
Impact