fix: apply per-tier topK truncation in searchMemory#1646
Merged
hijzy merged 1 commit intoMay 8, 2026
Conversation
The retrieval ranker's limit was the SUM of per-tier topK values
(e.g. topK={tier1:3,tier2:3,tier3:3} → limit=9), allowing merged
results to exceed the caller's expected total. Now searchMemory
enforces per-tier caps before returning hits, so topK=3 per tier
returns at most 3 results per tier instead of up to 9 total.
Fixes [BUG-2026-05-08] skill-type overflow in search results.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchMemory: the retrieval ranker's limit was the SUM of per-tier topK values (e.g.topK={tier1:3,tier2:3,tier3:3}→ limit=9), allowing merged results to exceed the caller's expected totaltopK=3per tier returns at most 3 results per tier instead of up to 9 totalTest plan
test_B2_S04_search_topk_respects_limitnow passes (was xfail before fix)