fix(MEMMY-399): silently ignore duplicate attachment drops - #388
Merged
syzsunshine219 merged 1 commit intoSep 10, 2026
Conversation
Skip the duplicate-only error toast after attachment validation filters out all incoming files. Preserve existing attachment identity and unsupported-file and read-failure error handling. Add HomePage drop interaction coverage for both composer views, repeated renamed files, mixed duplicate/new drops, and real validation failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MEMMY-399 duplicate attachment drag-and-drop on v1.1.5. Attachment validation already filters files that are present; the composer now returns quietly when a drop contains only duplicates, so no duplicateAttachment toast is shown. Unsupported file types and unreadable files still report their existing errors. Added HomePage interaction coverage for both composer views, repeated renamed files, mixed duplicate/new drops, unsupported files, and read failures. Validation: Project Harness Standard passed; focused HomePage attachment drop and memory refresh interaction tests passed (7/7); existing HomePage attachment tests passed (88/88). Base: v1.1.5.