Fix issues #158, #159, #160, and #161 - #226
Merged
chonilius merged 2 commits intoAug 28, 2026
Merged
Conversation
- Update README with Stellar Expert explorer links for all three deployed contracts (MergeFi#158) - Specify rust-version (MSRV) in workspace and package Cargo.toml files (MergeFi#159) - Add unit test for cancel_milestone rejecting double-cancel (MergeFi#160) - Add unit test for allocate rejecting closed milestone (MergeFi#161) - Fix duplicate error enum discriminants and require admin authorization in sweep
|
@chiscookeke11 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@chiscookeke11 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR resolves issues #158, #159, #160, and #161:
Stellar Expert Links in README (README's Stellar Expert link only covers the escrow contract #158):
mergefi-escrow,mergefi-milestones, andmergefi-maintenance-pool) inREADME.md.Workspace & Package MSRV / rust-version Metadata (Workspace Cargo.toml has no rust-version (MSRV) field #159):
rust-version = "1.95.0"under[workspace.package]in rootCargo.toml.rust-version.workspace = trueacross all workspace member crates (common,escrow,milestones, andmaintenance-pool).Milestones: Double-Cancel Rejection Test (milestones: cancel_milestone rejecting a double-cancel (MilestoneClosed) has no test #160):
test_cancel_milestone_rejects_double_cancelincontracts/milestones/src/test.rsto verify that callingcancel_milestoneon an already-cancelled milestone rejects withError::MilestoneClosed.Milestones: Allocate on Closed Milestone Rejection Test (milestones: allocate() on an already-closed milestone (MilestoneClosed) has no test #161):
test_allocate_rejects_closed_milestoneincontracts/milestones/src/test.rsto verify that callingallocateon a closed/cancelled milestone rejects withError::MilestoneClosed.Additional Fixes:
escrow,milestones, andmaintenance-poolerror definitions..require_auth()insweep.Closes #158
Closes #159
Closes #160
Closes #161