fix: distribute split dust by largest remainder - #31
Merged
Conversation
|
@bingmokaka is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_splitwith largest-remainder allocationTesting
rustup run stable-x86_64-pc-windows-gnu cargo check -p mergefi-escrow -p mergefi-milestones --target wasm32v1-noneI also attempted host tests with both MSVC and GNU Rust toolchains on this Windows machine. They did not complete because the local environment lacks MSVC SDK libs for the MSVC linker and then hit a Windows cdylib export ordinal linker issue under GNU. The contract code type-checks for the wasm target, and the PR includes focused unit tests for the changed behavior.
Fixes #6