merge queue: embarking main (eeac019) and #474 together#482
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: embarking main (eeac019) and #474 together#482mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The "Upload to GitHub release assets" step ran `curl --fail` under
`set +e`, then only treated exit code 22 as a failure
(`if [ $? = 22 ]`). When GitHub returned 422, curl actually exited with
56 ("Failure in receiving network data" - curl aborts the HTTP/2
transfer mid-stream when `--fail` trips), so the `= 22` check never
matched. With errexit disabled the loop finished and the step exited 0,
turning a rejected upload green.
Drop the exit-code guessing: run curl in an `if !` so any non-zero exit
(22, 56, network errors) triggers `exit 1`, and use `--fail-with-body`
so GitHub's error payload (the 422 detail) stays visible in the logs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Change-Id: Ia4cd0d86e9292735e26dffd2afacad1b6511ccd3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (eeac019) and #474 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #474.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:check-success=actionlintcheck-success=testtitle ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by >= 2author = dependabot[bot]body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0Required conditions to stay in the queue:
#approved-reviews-by>=2#changes-requested-reviews-by=0#review-requested=0#review-threads-unresolved=0check-success=actionlintcheck-success=testtitle ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by >= 2author = dependabot[bot]body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0