fix(design): address Phase 1 code review findings#11305
Draft
Conversation
Member
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Apr 29, 2026
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for:
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for:
This rule is failing.
🔴 🔎 ReviewsWaiting for:
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
- Add explanatory comment in HeadCommon.astro for the import order
(tokens → theme → typography → index) so future editors know it
is load-bearing, not arbitrary.
- Replace the blanket *.md ESLint ignore with a scoped fix to the
MDX block: place 'files' AFTER the mdxPlugin.flat spread to
override its default '**/*.{md,mdx}' glob and restrict remark
linting to .mdx only. This avoids silently suppressing future
*.md linting at the repo root.
Change-Id: I2e3f0a21f25eeb35ef685fc1d70df960974ade4e
jd
force-pushed
the
devs/jd/worktree-design/exclude-root-md-files-remark-lint-rules--68e7062f
branch
from
bf27f01 to
e52a449
Compare
jd
force-pushed
the
devs/jd/worktree-design/address-phase-1-code-review-findings--2e3f0a21
branch
from
f6e10ca to
36478ad
Compare
Member
Author
Revision history
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(tokens → theme → typography → index) so future editors know it
is load-bearing, not arbitrary.
MDX block: place 'files' AFTER the mdxPlugin.flat spread to
override its default '**/.{md,mdx}' glob and restrict remark
linting to .mdx only. This avoids silently suppressing future
*.md linting at the repo root.
Depends-On: #11304