fix(header): solid distinct navbar surface for light-mode readability#11308
Draft
Conversation
Member
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Apr 29, 2026
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for:
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for:
This rule is failing.
🔴 🔎 ReviewsWaiting for:
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
The previous navbar styling — body-bg-tinted color-mix at 95% opacity plus a backdrop blur — collapsed against the cleaner light gray introduced by the design-system token migration: links became hard to read because the navbar visually merged into the body bg. - Map --theme-navbar-bg to --theme-bg-content (white in light mode). Dark mode is unaffected because --theme-bg-content aliases --theme-bg there. - Drop the color-mix transparency and the backdrop-filter blur. The navbar is now a solid surface; the modern feel comes from the surface contrast plus the divider, not from glassmorphism. - Add a 1px bottom border using --theme-divider for clear separation. Change-Id: I2acd91b68a453f89a2ecdcc92324c976d6857315
jd
changed the title
jd
force-pushed
the
devs/jd/worktree-design/tighten-navbar-opacity-link-readability--2acd91b6
branch
from
d4a51c5 to
d8b4779
Compare
Member
Author
Revision history
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous navbar styling — body-bg-tinted color-mix at 95% opacity
plus a backdrop blur — collapsed against the cleaner light gray
introduced by the design-system token migration: links became hard to
read because the navbar visually merged into the body bg.
Dark mode is unaffected because --theme-bg-content aliases --theme-bg
there.
navbar is now a solid surface; the modern feel comes from the surface
contrast plus the divider, not from glassmorphism.
Depends-On: #11307