merge queue: embarking main (cf9c8b4) and #11661 together#11662
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: embarking main (cf9c8b4) and #11661 together#11662mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The 404 page renders `<Header />` without a `<LeftSidebar />`, but the
docs Header CSS assumes a sidebar exists at >=50em:
- `header { left: var(--theme-left-sidebar-width); }` shifts the navbar
right, leaving a 17rem empty gap on the left of the 404 navbar
- `.logo-mobile { display: none; }` hides the in-header logo on the
assumption that the sidebar's own logo takes over — but the sidebar
isn't there, so the 404 page renders with no logo at all
Override both rules on the 404 page so the header sits flush with the
viewport edge and the mobile-style logo stays visible at all widths.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Change-Id: I564d279c3dd61fc810b96c0a28740ca5f4dcd940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (cf9c8b4) and #11661 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #11661.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:schedule=Mon-Fri 09:00-17:30[Europe/Paris]title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-botbody ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
author != dependabot[bot]author != mergify-ci-bottitle ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-botbody ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/