fix(nav): keep the deprecated marker visible in the sidebar - #12691
Open
flagendijk89 wants to merge 1 commit into
Open
fix(nav): keep the deprecated marker visible in the sidebar#12691flagendijk89 wants to merge 1 commit into
flagendijk89 wants to merge 1 commit into
Conversation
Three action pages carried their status inside the nav label, and the
sidebar track was too narrow to hold it. The suffix was the part that
ellipsed away:
Delete Head Branch (De…
GitHub Actions (Deprec…
Post Check (Deprecated…
"GitHub Actions (Deprec…" sits in the same tree as the live GitHub
Actions integration page, so the one word separating them was the word
being cut.
Status moves out of the title into a `badge` field on NavItem, rendered
as its own pill. Because it is a separate element it is never what gets
truncated: it sits after the label where there is room and wraps beneath
it where there is not, deciding per row rather than per label, so it
keeps holding if a label is renamed or the sidebar is resized. No label
is shortened to protect it.
`--theme-left-sidebar-width` goes from 17rem to 18rem. The deepest rows
are indented twice and left 152px beside the icon — enough for a label,
not for a label plus a pill, so "GitHub Actions" pushed its pill onto a
second line. The extra 12px keeps every badged label but "Delete Head
Branch" inline, and costs the content column 12px. The right rail is
unchanged.
"GitHub Rulesets Compatibility" becomes "GitHub Rulesets", which now fits
without wrapping. The pill reads 9.4:1 in light and 10:1 in dark.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Change-Id: Ie8b27ca54974d6cb745292dacd61146b2776521a
Claude-Session-Id: 18413631-aa75-4182-9e79-4c1ce31bb683
Contributor
Merge Protections🟢 All 6 merge protections satisfied — ready to merge. Show 6 satisfied protections🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
sileht
approved these changes
Sep 5, 2026
jd
approved these changes
Sep 5, 2026
Contributor
Merge Queue Status
|
63 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of MRGFY-8998 — design polish review, August 2026. One of four independent PRs from that pass.
Three action pages carried their status inside the nav label, and the
sidebar track was too narrow to hold it. The suffix was the part that
ellipsed away:
"GitHub Actions (Deprec…" sits in the same tree as the live GitHub
Actions integration page, so the one word separating them was the word
being cut.
Status moves out of the title into a
badgefield on NavItem, renderedas its own pill. Because it is a separate element it is never what gets
truncated: it sits after the label where there is room and wraps beneath
it where there is not, deciding per row rather than per label, so it
keeps holding if a label is renamed or the sidebar is resized. No label
is shortened to protect it.
--theme-left-sidebar-widthgoes from 17rem to 18rem. The deepest rowsare indented twice and left 152px beside the icon — enough for a label,
not for a label plus a pill, so "GitHub Actions" pushed its pill onto a
second line. The extra 12px keeps every badged label but "Delete Head
Branch" inline, and costs the content column 12px. The right rail is
unchanged.
"GitHub Rulesets Compatibility" becomes "GitHub Rulesets", which now fits
without wrapping. The pill reads 9.4:1 in light and 10:1 in dark.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
🤖 Generated with Claude Code