-
Notifications
You must be signed in to change notification settings - Fork 10
feat: allow to pass base/head sha to ci scopes #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to pass base/head sha to ci scopes #850
Conversation
|
This pull request is part of a stack:
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
🧪 CI InsightsHere's what we observed from your CI run for a4482a2. 🟢 All jobs passed!But CI Insights is watching 👀 |
2aea386 to
da8d1a4
Compare
cf4d240 to
4e584d5
Compare
|
@sileht this pull request is now in conflict 😩 |
4e584d5 to
bce8bbc
Compare
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the scopes detection functionality to accept base/head git references as explicit parameters instead of relying on automatic detection through a dependency. The main goal is to decouple the detect function from the git_refs.detector module while still allowing the CLI to auto-detect references when needed.
Key changes:
- Modified
scopes_cli.detect()to accept explicitbase,head, andis_merge_queueparameters - Updated CLI command to add optional
--baseand--headflags with auto-detection fallback - Removed
base_refandhead_reffields fromDetectedScopemodel
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mergify_cli/ci/scopes/cli.py | Added required parameters to detect() function and removed git ref fields from DetectedScope model |
| mergify_cli/ci/cli.py | Added optional CLI flags for base/head with fallback to auto-detection |
| mergify_cli/tests/ci/scopes/test_cli.py | Updated tests to pass explicit parameters and removed assertions on removed fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@sileht this pull request is now in conflict 😩 |
This will helps debuging scenario locally. Change-Id: I5f2d78ce99243ce506edc1db6f1a61b4f023fa2e
bce8bbc to
a4482a2
Compare
Pull request has been modified.
|
✅ The pull request has been merged |
This will help debug some scenarios locally.
This adds
--baseand--headtomergify ci scopes