Skip to content

Conversation

@sileht
Copy link
Member

@sileht sileht commented Oct 28, 2025

This will help debug some scenarios locally.
This adds --base and --head to mergify ci scopes

@mergify mergify bot had a problem deploying to Mergify Merge Protections October 28, 2025 17:17 Failure
@sileht
Copy link
Member Author

sileht commented Oct 28, 2025

This pull request is part of a stack:

  1. feat: allow to pass base/head sha to ci scopes (#850) 👈

@sileht sileht mentioned this pull request Oct 28, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= .{48,}

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2025

🧪 CI Insights

Here's what we observed from your CI run for a4482a2.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot requested a review from a team October 28, 2025 17:20
@sileht sileht force-pushed the devs/sileht/cli-base-head/Icb5600688e5e32737e4070feda736ee181d49c8c branch from 2aea386 to da8d1a4 Compare October 29, 2025 07:23
@sileht sileht force-pushed the devs/sileht/cli-base-head/I5f2d78ce99243ce506edc1db6f1a61b4f023fa2e branch from cf4d240 to 4e584d5 Compare October 29, 2025 07:23
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 29, 2025 07:23 Failure
remyduthu
remyduthu previously approved these changes Oct 29, 2025
Base automatically changed from devs/sileht/cli-base-head/Icb5600688e5e32737e4070feda736ee181d49c8c to main October 29, 2025 09:02
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Oct 29, 2025
Syffe
Syffe previously approved these changes Oct 29, 2025
Copilot AI review requested due to automatic review settings October 29, 2025 09:29
@sileht sileht force-pushed the devs/sileht/cli-base-head/I5f2d78ce99243ce506edc1db6f1a61b4f023fa2e branch from 4e584d5 to bce8bbc Compare October 29, 2025 09:29
@mergify mergify bot removed the conflict label Oct 29, 2025
@mergify mergify bot dismissed stale reviews from Syffe and remyduthu October 29, 2025 09:30

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections October 29, 2025 09:30 Failure
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the scopes detection functionality to accept base/head git references as explicit parameters instead of relying on automatic detection through a dependency. The main goal is to decouple the detect function from the git_refs.detector module while still allowing the CLI to auto-detect references when needed.

Key changes:

  • Modified scopes_cli.detect() to accept explicit base, head, and is_merge_queue parameters
  • Updated CLI command to add optional --base and --head flags with auto-detection fallback
  • Removed base_ref and head_ref fields from DetectedScope model

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
mergify_cli/ci/scopes/cli.py Added required parameters to detect() function and removed git ref fields from DetectedScope model
mergify_cli/ci/cli.py Added optional CLI flags for base/head with fallback to auto-detection
mergify_cli/tests/ci/scopes/test_cli.py Updated tests to pass explicit parameters and removed assertions on removed fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify bot requested a review from a team October 29, 2025 09:31
JulianMaurin
JulianMaurin previously approved these changes Oct 29, 2025
Syffe
Syffe previously approved these changes Oct 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Oct 29, 2025
This will helps debuging scenario locally.

Change-Id: I5f2d78ce99243ce506edc1db6f1a61b4f023fa2e
@sileht sileht force-pushed the devs/sileht/cli-base-head/I5f2d78ce99243ce506edc1db6f1a61b4f023fa2e branch from bce8bbc to a4482a2 Compare October 29, 2025 14:01
@mergify mergify bot removed the conflict label Oct 29, 2025
@mergify mergify bot dismissed stale reviews from Syffe and JulianMaurin October 29, 2025 14:02

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections October 29, 2025 14:02 Active
@mergify mergify bot requested a review from a team October 29, 2025 14:04
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2025

✅ The pull request has been merged

mergify bot added a commit that referenced this pull request Oct 30, 2025
@mergify mergify bot added the queued label Oct 30, 2025
@mergify mergify bot merged commit 9e21656 into main Oct 30, 2025
10 checks passed
@mergify mergify bot deleted the devs/sileht/cli-base-head/I5f2d78ce99243ce506edc1db6f1a61b4f023fa2e branch October 30, 2025 10:18
@mergify mergify bot removed the queued label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants