merge queue: embarking main (73c647a), #254 and #252 together#256
Closed
mergify[bot] wants to merge 4 commits intomainfrom
Closed
merge queue: embarking main (73c647a), #254 and #252 together#256mergify[bot] wants to merge 4 commits intomainfrom
mergify[bot] wants to merge 4 commits intomainfrom
Conversation
The compare function was using list comparison for SQL statements, which meant statement ordering differences (e.g. from different pg_dump versions) would cause false negatives. Changes: - Use set comparison instead of list for order-independent matching - Filter out psql meta-commands (\unrestrict, etc.) that vary between pg_dump runs and are not part of the SQL schema - Filter out non-SQL statements (no keywords) like empty lines - Fix UnorderedTokenList.tokens missing return after empty parens case Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: I8afac054920f759cb69ce0e1a8f73df6f842715d
Ignore new RUF067 (single-module library) and PLW1514 (SQL files are always UTF-8) rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: Id3981aa68028d69d07d5a406ca5b5c15e9369b95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (73c647a), #254 and #252 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #252.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0Required conditions to stay in the queue:
#approved-reviews-by>=1#changes-requested-reviews-by=0#review-requested=0#review-threads-unresolved=0check-success = semgrepcheck-success=Test with Python 3.10check-success=Test with Python 3.11check-success=Test with Python 3.12check-success=Test with Python 3.9title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:body ~= (?ms:.{48,})#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0