fix: nodes list UX, chat auto-poll, topnodes channel scoping, and timestamp fixes#424
Merged
SimmerV merged 7 commits intoMeshAddicts:developfrom Apr 8, 2026
Merged
fix: nodes list UX, chat auto-poll, topnodes channel scoping, and timestamp fixes#424SimmerV merged 7 commits intoMeshAddicts:developfrom
SimmerV merged 7 commits intoMeshAddicts:developfrom
Conversation
… click-outside deselection
…/unfreeze lifecycle
…cord channel (closes MeshAddicts#423)
… Discord channel (closes MeshAddicts#423)
…ture node clocks on ingestion (closes MeshAddicts#422)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves several live-update UX and data-scoping behaviors across the frontend, Discord bot, and ingestion pipeline, addressing multiple reported issues around list stability, chat polling, channel-specific leaderboards, and timestamp formatting.
Changes:
- Stabilizes the Nodes list during live polling (freeze-on-scroll/selection, deep-link scroll/highlight, click-outside deselect).
- Enables auto-polling on Chat when live mode is active.
- Scopes
/topnodesresults to a mapped mesh channel and fixes several timestamp display/ingestion issues (local formatting + clamp future rx_time).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| storage/db/postgres.py | Adds optional channel_id filter support to leaderboard queries (and scopes Iron Man by last_channel). |
| mqtt.py | Clamps future rx_time timestamps during MQTT ingestion with a warning log. |
| frontend/src/pages/traceroutes/TracerouteDetailsPanel.tsx | Removes raw UTC ISO timestamp rendering in favor of formatted timestamps. |
| frontend/src/pages/nodes/NodesList.tsx | Implements list-freezing, new-item counting, and improved deep-link scrolling via Virtuoso + DOM fallback. |
| frontend/src/pages/Nodes.tsx | Adds click-outside deselect + deep-link-only auto-scroll, and updates live-pill paused logic for selection. |
| frontend/src/pages/map/detailsHtml.ts | Formats “Last Seen” in node map details to local time instead of raw ISO/UTC. |
| frontend/src/pages/Chat.tsx | Adds RTK Query polling options tied to liveEnabled (interval + focus/reconnect behavior). |
| bot/cogs/main_commands.py | Scopes /topnodes to the mesh channel mapped from the Discord channel and adjusts embed title/footer accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?node=xyz) auto-scrolls to and highlights the selected node/topnodesleaderboard to the mesh channel when run in a mapped Discord channel (closes Bug: discord bot /topnodes pulls combined results #423)Changes
Frontend
displayItemsvia useMemo, new-item counter, "Back to top (N new)" button clears selection, native DOMscrollIntoViewfallback for deep link scrollliveUiModeshows "paused" when node selected,scrollToIdcleared on deselecturlChchannel param supportpollingInterval: 5000withskipPollingIfUnfocusedwhen live enabledlast_seento local time viatoLocaleString()instead of raw ISO string.toISOString()UTC displaysBackend
rx_timeto current time when node clock is >5 min ahead, log warning with node ID and drift/topnodesreverse-looks up Discord channel → mesh channel hash via bridge config, filters Chatterbox/Loudest Signal/Gateway MVP/Iron Man queries by channel;defer()moved to first linequery_top_nodesaccepts optionalchannel_idfilter for chat-based and node-based stats