Move MRMeshBoolean gtests to MRTest project#6132
Merged
Merged
Conversation
Move the two gtest cases from source/MRMesh/MRMeshBoolean.cpp (MeshBoolean, BooleanMultipleEdgePropogationSort) into a new file source/MRTest/MRMeshBooleanTests.cpp. Also port testBooleanMapper from source/MRTestC2/MRMeshBoolean.c (the only non-duplicate among the C tests) as a new C++ gtest "MRMesh, BooleanResultMapper" in the same file. Drop now-unused includes from MRMeshBoolean.cpp (MRGTest, MRTorus, MRCube, MRMatrix3).
Grantim
approved these changes
May 21, 2026
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TEST(MRMesh, ...)cases out ofsource/MRMesh/MRMeshBoolean.cppinto a newsource/MRTest/MRMeshBooleanTests.cpp:MRMesh, MeshBooleanMRMesh, BooleanMultipleEdgePropogationSortsource/MRTestC2/MRMeshBoolean.c. Of the three C tests:testMeshBoolean— duplicate of the moved C++MeshBoolean(same torus sweep, only minor differences in which operations are checked)testBooleanMultipleEdgePropogationSort— duplicate of the moved C++BooleanMultipleEdgePropogationSorttestBooleanMapper— not duplicated in C++. Ported into the new file asTEST(MRMesh, BooleanResultMapper)coveringBooleanResultMapper::map,newFaces, and thegetMapsaccessors with the same hardcoded expected sizes/counts.MRMeshBoolean.cpp(MRGTest,MRTorus,MRCube,MRMatrix3).MRMeshBooleanTests.cpptosource/MRTest/MRTest.vcxprojand.vcxproj.filters(CMake side picks it up viafile(GLOB SOURCES "*.cpp")automatically).Test plan
MRTestbuilds on every platform (Windows MSBuild + CMake, Linux GCC/Clang x64/arm64, macOS x64/arm64, Emscripten st/mt/mt-64, vcpkg) — all build-test jobs green[ OK ] MRMesh.MeshBoolean (267 ms)[ OK ] MRMesh.BooleanMultipleEdgePropogationSort (4 ms)[ OK ] MRMesh.BooleanResultMapper (2 ms)MRMeshlibrary still builds with the trimmed include list (MRMesh.dll/libMRMesh.solink without errors)MRTestC2continues to build (no tests were removed from it by this PR)