Port MRFixSelfIntersections tests from MRTestC2 to MRTest#6145
Merged
Conversation
Convert the testFixSelfIntersections case from source/MRTestC2/MRFixSelfIntersections.c into a new gtest source/MRTest/MRFixSelfIntersectionsTests.cpp using the regular C++ API (makeTorusWithSelfIntersections, SelfIntersections::getFaces / fix). Also register the new file in MRTest.vcxproj and MRTest.vcxproj.filters (the CMake build uses a *.cpp glob and picks it up automatically).
Grantim
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the
testFixSelfIntersectionstest case fromsource/MRTestC2/MRFixSelfIntersections.cto a regular C++ gtest in a new filesource/MRTest/MRFixSelfIntersectionsTests.cpp, following the pattern established forMRMeshBooleanin #6132.The new test (
MRMesh.FixSelfIntersections):makeTorusWithSelfIntersections;SelfIntersections::fixwithCutAndFillandtouchIsIntersection=false;MRTest.vcxproj/.vcxproj.filtersare updated to include the new file; the CMake build picks it up via the existing*.cppglob.The original C test is left in place for now.