Add mimalloc and dbus to third-party notices, list c-blosc in ThirdpartyList#6434
Merged
Conversation
Ship-check of real CI artifacts confirmed both are distributed (mimalloc.dll beside the Windows executables, libdbus in the linux-vcpkg archive) but were missing from the manifest and notices. c-blosc already shipped with notices and only ThirdpartyList.dox was missing it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Grantim
added
the
update-doc-only
Fedr
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciles the user-facing third-party lists with what the SDK actually ships, closing the gaps found while curating the license notices.
mimalloc (MIT) and dbus (AFL-2.1 OR GPL-2.0-or-later) are distributed but were missing from
manifest.json/THIRD-PARTY-NOTICES.txtand from the Doxygen list -- verified by opening real CI artifacts:mimalloc.dll+mimalloc-redirect.dllship next to the bundled executables (MeshViewer.exe,meshconv.exe, ...); WebAssembly builds embed Emscripten's bundled mimalloc (-sMALLOC=mimalloc, default ON).libdbus-1.so.3.38.3+ headers ship; dbus is a direct MRViewer dependency on Linux (MRFileDialogPortal.cpp, xdg-desktop-portal file dialogs). The ubuntu deb links the system libdbus and bundles nothing, like other system deps.Both get a manifest entry (vcpkg-registry version pin) and a verbatim-text section in
THIRD-PARTY-NOTICES.txt(dbus: the 1.16.2COPYING+LICENSES/AFL-2.1.txt+LICENSES/GPL-2.0-or-later.txt; mimalloc: upstreamLICENSE).c-blosc (BSD-3-Clause, direct submodule, used by OpenVDB in MRVoxels) already shipped with notices; it was only missing from
ThirdpartyList.dox. Added there, plus a short "Bundled executables" section for mimalloc and a D-Bus row under MRViewer.Test plan
python scripts/check_third_party_licenses.pygreen: 43 components, both new entries pinned to the registry baseline, section structure validated.update-doc-only).