Jules release8 - #13
Merged
Jenny Hickson (jennyhickson) merged 6 commits intoDec 9, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
requested a review
from Jenny Hickson (jennyhickson)
December 8, 2025 14:16
James Bruten (james-bruten-mo)
marked this pull request as ready for review
December 8, 2025 14:16
Jenny Hickson (jennyhickson)
approved these changes
Dec 8, 2025
Jenny Hickson (jennyhickson)
left a comment
Collaborator
There was a problem hiding this comment.
This all looks fine
Collaborator
|
Before commit it would be ideal if the SimSys_Scripts version in dependencies.yaml could be updated to the tag - but thats a nice to have. |
James Bruten (james-bruten-mo)
requested a review
from Jenny Hickson (jennyhickson)
December 8, 2025 14:59
Jenny Hickson (jennyhickson)
approved these changes
Dec 8, 2025
Jenny Hickson (jennyhickson)
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Jenny Hickson (@jennyhickson)
Changes for Jules vn8.0
Aside from the standard changes for the release, there are a few modifications to
rose-stem/bin/create_jules_version_metadata.pyto allow it to run from gitCode Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
rose-meta/jules-sharedthen have you supplied a linked UM PR?Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Test Suite Results - jules - jules_vn8/run1
Suite Information
Task Information
✅ succeeded tasks - 667
Test Suite Results - um - um_for_jules8/run1
Suite Information
Approvals
Code Owners
Config Owners
No UM Config Owners Required
Task Information
✅ succeeded tasks - 880
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review