transmute aerosol_ukca_kernel_mod - #691
Open
Benjamin Went (MetBenjaminWent) wants to merge 15 commits into
Open
Conversation
Benjamin Went (MetBenjaminWent)
added a commit
to MetBenjaminWent/lfric_apps
that referenced
this pull request
Aug 5, 2026
Benjamin Went (MetBenjaminWent)
marked this pull request as ready for review
August 6, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
#607 has run into issues compiling aerosol_ukca_kernel_mod and conv_comorph_kernel_mod after they have been Transmuted with CCE.
This PR gets
aerosol_ukca_kernel_modworking, but sadly notconv_comorph_kernel_mod(which runs into a compiler bug for CCE when adding OMP).After discussing possible causes with STFC, we think the best course is to:
-hipa0Sci/Tech Reviewer:
Code Reviewer:
Issue: #657
Umbrella: #424
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - aero_ukca_conv_como_explore/run26
Suite Information
Task Information
✅ succeeded tasks - 51
Test Suite Results - lfric_apps - aero_ukca_conv_como_explore/run25
Suite Information
Task Information
✅ succeeded tasks - 1216
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review