PS49 radiation diags - #707
Open
iboutle wants to merge 5 commits into
Open
Conversation
added 4 commits
August 11, 2026 13:23
Extract the open sea tile of surf_sw_net and rescale it by the open water fraction of the marine part of the grid box, giving the net downward shortwave flux from open sea as a mean over sea and sea-ice. This needs no Fortran: surf_sw_net is already written on tiles. Some of the content of this change has been produced with the assistance of Anthropic Claude Opus 5 (Claude Code).
Form the net downward longwave flux on tiles as the difference of the tiled downward and upward longwave fluxes, extract the open sea tile, then rescale by the open water fraction of the marine part of the grid box to give a mean over sea and sea-ice. As for the shortwave, this needs no Fortran: both tiled fluxes are already written. Some of the content of this change has been produced with the assistance of Anthropic Claude Opus 5 (Claude Code).
The direct flux in the first shortwave band is the direct UV flux for the standard spectral files, whose first band spans the ultraviolet. That band occupies the leading radiation_levels entries of the combined band and level axis of sw_direct_band_rts, so a zoom onto them selects the whole column in that band. The zoom length depends on the number of model levels, so it has to be set by the model rather than declared in the axis definition. Some of the content of this change has been produced with the assistance of Anthropic Claude Opus 5 (Claude Code).
The upward and downward band fluxes are packed on the combined band and level axis exactly as the direct flux is, so the first band of each can be selected by the zoom added for the direct UV flux, with no further axis or model changes. Some of the content of this change has been produced with the assistance of Anthropic Claude Opus 5 (Claude Code).
github-actions
Bot
added
the
cla-modified
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: James Manners (@mo-jmanners)
Code Reviewer: Matthew Walker (@mattatmet)
Several more radiation diagnostics requested by PS49
1-203surface__sea_mean_sw_net1-212radiation__direct_uv_flux_rts1-213radiation__up_uv_flux_rts1-214radiation__down_uv_flux_rts2-203surface__sea_mean_lw_netSome plots of the output:
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - rad_diags/run1
Suite Information
Task Information
✅ succeeded tasks - 1213
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review