fix: remove skeleton double rendering in browse pass#161
Merged
afonsobspinto merged 10 commits intoMay 14, 2026
Merged
Conversation
also indicate via comments diff paths and clear seg hasSelectedSegment
seankmartin
changed the title
this allows us to be more maintainable. This bug stemmed from the isReady using a different path for chunk manage then the rendering did
afonsobspinto
approved these changes
May 14, 2026
fix: correct isReady check on spatial skeleton layers
feat: add saturation support and seg higlight to spatial skeleton render
afonsobspinto
merged commit 4f7b6fa
into
refactor/review-skeletons-logic
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core piece of this is to have a cullPosition set in the vertex shader as a non flat varying so that it is interpolated across fragments in between the nodes. Then setting up uniforms for chunk bounds for each chunk and comparing in the fragment shader the cull pos against these chunk bounds - and discarding based on that.
However, there is a bit of changes needed through the frontend to correctly route all this information. On the bright side, it also fixes the wireframe rendering vis too.
Had considered using glCullDistance but seems that with our custom line rendering this might be likely to cause issues