fix: panic on full-width IP-SUFFIX rules#2975
Merged
Merged
Conversation
Collaborator
|
It might look better to place the conditions on a single line, joined by |
Author
|
Sure. |
Collaborator
|
Your current submission contains compilation errors; please revise it. |
Author
|
Fixed. |
Author
|
The 1 failed test on windows seems unrelated to this pull request. |
Collaborator
|
Don't worry, we will merge them later when we have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPSuffix.Matchpanics with index out of range [-1] when a rule uses a full-byte suffix such asIP-Suffix,1.2.3.4/32and a connection's address matches that suffix exactly.When
bits%8 == 0, the full-byte loop already validated the entire suffix, so the sub-byte check is unnecessary (and the<< 8shift would be a no-op anyway).To reproduce the panic:
- IP-SUFFIX,1.1.1.1/32,DIRECTto your first rule.curl 1.1.1.1.