Improve typesafety and use yarn workspaces#2
Merged
Conversation
pacwoodson
reviewed
Apr 18, 2020
pacwoodson
left a comment
pacwoodson
left a comment
Member
There was a problem hiding this comment.
It seems that yarn v2 workspaces are still incompatible with React Native then Expo...
| @@ -0,0 +1 @@ | |||
| declare module '@walletconnect/web3-provider'; | |||
Member
There was a problem hiding this comment.
This is strange, as the package repository seems to have the file but not the npm package :/
Contributor
Author
There was a problem hiding this comment.
Yea they don’t have proper types in there either, so it’s not really typesafe either way, this is just to silence the warning in strict mode
vidvidvid
pushed a commit
that referenced
this pull request
Feb 8, 2022
…pportunity.md removed # from file name
Closed
vidvidvid
added a commit
that referenced
this pull request
Nov 7, 2022
vidvidvid
added a commit
that referenced
this pull request
Nov 9, 2022
vidvidvid
added a commit
that referenced
this pull request
Nov 14, 2022
vidvidvid
added a commit
that referenced
this pull request
Nov 15, 2022
vidvidvid
added a commit
that referenced
this pull request
Nov 16, 2022
alalonde
pushed a commit
that referenced
this pull request
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves type safety by enabling strict mode and enables yarn workspaces to make managing monorepo easier