Skip to content

Fix GraphQL codegen#3

Merged
META-DREAMER merged 3 commits into
masterfrom
fix/graphql-codegen
Apr 18, 2020
Merged

Fix GraphQL codegen#3
META-DREAMER merged 3 commits into
masterfrom
fix/graphql-codegen

Conversation

@META-DREAMER

@META-DREAMER META-DREAMER commented Apr 18, 2020

Copy link
Copy Markdown
Contributor

The problem was that the introspection query didnt have the admin-secret in the auth header, so it wasn't able to get the mutation types.

Currently this is still as a separate package, but we should update the app-react queries to use the generated types now instead.

@META-DREAMER META-DREAMER requested a review from pacwoodson April 18, 2020 06:45
@pacwoodson

Copy link
Copy Markdown
Member

Well done.
Those generated files will be used by app-react indeed, but I think better that it stays in a different package as other packages may be also requiring them.

@META-DREAMER

Copy link
Copy Markdown
Contributor Author

@pakokrew yea normally it generates types based on the query defined in the component, but the fragment first approach with codegen-Hasura might make it more reusable.

@META-DREAMER META-DREAMER merged commit 545b243 into master Apr 18, 2020
@pacwoodson pacwoodson deleted the fix/graphql-codegen branch July 12, 2020 10:40
vidvidvid pushed a commit that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants