Fix GraphQL codegen#3
Merged
Merged
Conversation
Member
|
Well done. |
pacwoodson
approved these changes
Apr 18, 2020
Contributor
Author
|
@pakokrew yea normally it generates types based on the query defined in the component, but the fragment first approach with codegen-Hasura might make it more reusable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that the introspection query didnt have the admin-secret in the auth header, so it wasn't able to get the mutation types.
Currently this is still as a separate package, but we should update the app-react queries to use the generated types now instead.